Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the main Pymaker class #404

Merged
merged 11 commits into from May 8, 2024
Merged

Refactor the main Pymaker class #404

merged 11 commits into from May 8, 2024

Conversation

seapagan
Copy link
Owner

@seapagan seapagan commented May 8, 2024

Start splitting some functionality out of the Pymaker class and into grouped support functions.

Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@seapagan seapagan added the refactor Internal refactoring of code or linting etc label May 8, 2024
@seapagan seapagan self-assigned this May 8, 2024
Copy link

codacy-production bot commented May 8, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.62% (target: -1.00%) 3.94%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5cae94b) 586 198 33.79%
Head commit (d320921) 612 (+26) 203 (+5) 33.17% (-0.62%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#404) 127 5 3.94%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@seapagan seapagan changed the title General code refactoring Refactor the main Pymaker class May 8, 2024
@seapagan seapagan marked this pull request as ready for review May 8, 2024 11:57
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@seapagan seapagan merged commit aacdf54 into main May 8, 2024
13 checks passed
@seapagan seapagan deleted the refactoring branch May 8, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Internal refactoring of code or linting etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant