This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Add a Force-merge command #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"wait_for_merge" has been removed from official documentation in ES 1.5, though this was not mentioned in the breaking changes. "refresh" has never been documented for the Optimize API, though it is for other APIs such as Index (https://www.elastic.co/guide/en/elasticsearch/reference/2.4/docs-index_.html#index-refresh) or Get (https://www.elastic.co/guide/en/elasticsearch/reference/2.4/docs-get.html#get-refresh). See: * https://www.elastic.co/guide/en/elasticsearch/reference/1.4/indices-optimize.html * https://www.elastic.co/guide/en/elasticsearch/reference/1.5/indices-optimize.html * https://www.elastic.co/guide/en/elasticsearch/reference/2.0/indices-optimize.html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Optimize command and adds support for the Force-merge API, which replaces the Optimize API as of ES 2.1.
The whole thing is pretty much a copy-paste of the Optimize command and its tests. I did not remove the Optimize command because it's still needed for users of Elasticsearch 2.0.
Note that this additional command is only "nice" when using ES 2.x, but it is actually required when using Elasticsearch 5.0, in which the Optimize API has been completely removed.
Related issue (kind of): #292