Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isFilterSelected ignores filter level #1144

Closed
McManning opened this issue Aug 30, 2022 · 1 comment
Closed

isFilterSelected ignores filter level #1144

McManning opened this issue Aug 30, 2022 · 1 comment
Labels

Comments

@McManning
Copy link
Contributor

The problem

For hierarchical facets: isFilterSelected returns true if a filter exists that matches the same identifier + value, regardless of what level the filter is defined.

Details

Assume the (terrible, but unfortunately real) use case:

image

If the active filter is { identifier: 'category', value: 'Instrument', level: 1 } then a potential filter of { identifier: 'category', value: 'Instrument', level: 2 } will also be considered selected.

@stale
Copy link

stale bot commented Jan 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 7, 2023
@stale stale bot closed this as completed May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant