Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RangeFacet not using min / max ranges #827

Closed
joemcelroy opened this issue Dec 19, 2020 · 1 comment
Closed

RangeFacet not using min / max ranges #827

joemcelroy opened this issue Dec 19, 2020 · 1 comment

Comments

@joemcelroy
Copy link
Member

Component has been hardcoded to use min / max 0 /100. Needs to use the configured min / max ranges. Solution is to use the entries response, figure out the min and max values from array and provide them as the boundaries for the component.
joemcelroy added a commit that referenced this issue Dec 20, 2020
@joemcelroy
fix(rangeslider): fix slider when boundaries are not 0-100
ee22887 
specify the boundaries based on the levels. Generate better levels to indicate where results are

#827
joemcelroy added a commit that referenced this issue Dec 20, 2020
@joemcelroy
RangeSlider fix: Level indications + flexible boundaries + Removing 0…
8c5dc39 
… min range filters (#828)

* fix(rangeslider): fix slider when boundaries are not 0-100

specify the boundaries based on the levels. Generate better levels to indicate where results are

#827

* fix(client): bug fix for unable to remove filter when range min is 0

when the range filter min is 0, failed to remove the filter

* feat: re-order facets

* style: eslint

* release 23
@joemcelroy
Copy link
Member Author

released rc23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joemcelroy