Force toString() conversion of bemBlock classes in order to prevent ReactJS from ignoring className attribute #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eactJS from ignoring className attribute.
|
|
|
Looks like there is already something done to fix that #519 Waiting for the solution to be reviwed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactJS 16 throws warning and ignores className attribute in case if it is not a string.
In order to prevent it the Bem-cn library suggests to force toString() conversion of bemBlock classes.
This merge request forces SearchBox and InputFilter related classes to be converted to string explicitly.