Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated _all in SuggestionsAccessor #589

Merged
merged 1 commit into from Jan 5, 2018
Merged

Replace deprecated _all in SuggestionsAccessor #589

merged 1 commit into from Jan 5, 2018

Conversation

Xrampino
Copy link

@Xrampino Xrampino commented Jan 5, 2018

_all field is deprecated in ES 6.0.0. See https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-all-field.html

As such, direct_generator, referenced in SuggestionsAccessor, is no longer operational. This PR adresses this, by using directly the current field instead. Since there is no longer a standard catchall field, keeping the generation on a catchall field was not possible.

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.69% when pulling c3bc51b on Xrampino:develop into e0df076 on searchkit:develop.

@ssetem
Copy link
Member

ssetem commented Jan 5, 2018

hi @Xrampino

Thanks for the PR, do you know if this is backwards compatible with es5 etc?

@Xrampino
Copy link
Author

Xrampino commented Jan 5, 2018

Sure, I forgot to tell it in my PR description, but this can be any field, back since ES2 : https://www.elastic.co/guide/en/elasticsearch/reference/2.0/search-suggesters-phrase.html

field : The field to fetch the candidate suggestions from.

@ssetem
Copy link
Member

ssetem commented Jan 5, 2018

nice @Xrampino thanks

@ssetem ssetem merged commit 97da842 into searchkit:develop Jan 5, 2018
@Milananas
Copy link

Is there already a stable release with this change? Or is there a way around it in the current release?

@christopher-johnson
Copy link

@ssetem
can you cut a new release with this commit please? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants