Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window is undefined on server side, fixed invalid logic in SSR support #598

Merged
merged 1 commit into from
Jan 24, 2018
Merged

window is undefined on server side, fixed invalid logic in SSR support #598

merged 1 commit into from
Jan 24, 2018

Conversation

moersoy
Copy link
Contributor

@moersoy moersoy commented Jan 23, 2018 

window is not defined
ReferenceError: window is not defined
    at Object.exports.supportsHistory (/node_modules/searchkit/src/core/history.ts:13:12)

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.69% when pulling 8336fa8 on moersoy:develop into 6e308b3 on searchkit:develop.

@ssetem
Copy link
Member

ssetem commented Jan 24, 2018

thanks @moersoy

@ssetem ssetem merged commit 9cd00cd into searchkit:develop Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@moersoy @CLAassistant @coveralls @ssetem