Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect if page content has changed #94

Closed
m-i-l opened this issue Mar 12, 2023 · 1 comment
Closed

Detect if page content has changed #94

m-i-l opened this issue Mar 12, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@m-i-l
Copy link
Contributor

m-i-l commented Mar 12, 2023 •
edited

Request page content, and compare with the previously indexed content for that page. If the content hasn't changed, set a flag for later use during indexing, and update a new page property, e.g. page_last_change_detected, for possible later use after indexing.

This is primarily to ensure that any computationally expensive work for #84 "Connecting people" functionality, e.g. find similar blogs to your own is only executed where necessary, i.e. when the content has actually changed. It could also be used to for #95 .

Note that this is different from #34 "Add an incremental reindex (only indexing new items)", which aimed to not request pages if it didn't think they had changed, rather than work out if a page has changed after requesting it.
@m-i-l m-i-l added the enhancement New feature or request label Mar 12, 2023
@m-i-l m-i-l mentioned this issue Mar 25, 2023
Open
@m-i-l m-i-l mentioned this issue Jun 24, 2023
Closed
m-i-l added a commit that referenced this issue Jun 25, 2023
@m-i-l
Added get_contents to get previously indexed page contents, for #94 D…
1f88c7e 
…etect if page content has changed
m-i-l added a commit that referenced this issue Jun 25, 2023
@m-i-l
Added content_last_modified field, for #94 Detect if page content has…
12d86f2 
… changed
m-i-l added a commit that referenced this issue Jun 25, 2023
@m-i-l
Implemented #94: Detect if page content has changed
a062e31
m-i-l added a commit that referenced this issue Jul 8, 2023
@m-i-l
Changed the number of sites which will be concurrently indexed from 1…
f257d64 
…6 to 8, given #99 and #94 will significantly increase memory usage during indexing
@m-i-l m-i-l closed this as completed Jul 8, 2023
@m-i-l
Copy link
Contributor Author

m-i-l commented Jul 8, 2023

Released in v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@m-i-l