Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to configure binary file extension #89

Merged
merged 6 commits into from
Apr 23, 2023

Conversation

cobcobs
Copy link
Contributor

@cobcobs cobcobs commented Apr 22, 2023

Addresses #77

@searleser97
Copy link
Owner

searleser97 commented Apr 22, 2023

Instead of adding this behavior as default, let's better add an option in the configuration file that lets the user decide if they want to use .exe extension when using Unix systems

@cobcobs
Copy link
Contributor Author

cobcobs commented Apr 23, 2023

I have rewritten it to allow the user to specify a file extension for the binary (it defaults to exe) via the following in cpbooster-config.json:

{
  "executableFileExtension": "",
}

It also accounts for the user including unnecessary periods (e.g. "executableFileExtension": ".exe"), but I do not know if that behavior should be kept as it isn't consistent with the behavior of preferredLang.

@cobcobs cobcobs changed the title Check OS before appending file extension Allow user to configure binary file extension Apr 23, 2023
@searleser97 searleser97 self-requested a review April 23, 2023 01:57
@searleser97 searleser97 merged commit 67af3cd into searleser97:develop Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants