Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blow up when current branch is master #4

Closed
searls opened this issue May 15, 2019 · 2 comments
Closed

Blow up when current branch is master #4

searls opened this issue May 15, 2019 · 2 comments

Comments

@searls
Copy link
Owner

searls commented May 15, 2019

One idea would be to blow up only if it's been merged to master. This is sneaky and evil from a CI perspective but could be one way to detect something you want to remove after a feature branch is merged but the dates aren't clear/meaningful.

I presume we'd do this by shelling out to git b/c lazy

@jasonkarns
Copy link

I think I'd rather prefer to use the proposed if predicate (or wrapping in a vanilla conditional) where the condition checks for "evidence of the PR being merged".

ie, if the feature PR adds a new method to an object, I'd rather write a todo on master that blows up if the desired method exists.

(I assume this is in cases where the PR in question couldn't take care of the todo item itself...)

@searls
Copy link
Owner Author

searls commented Sep 10, 2019

👍 agree

@searls searls closed this as completed Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants