Static Code Analysis #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrate changes
# Conflicts: # src/main/java/usi/si/seart/repository/GitRepoRepository.java
Integrate changes
- Metrics not getting stored Method GitRepoServiceImpl::createOrUpdateRepo was missing statements to copy over field values - Migration file V2 missing - Hikari pool size settings was missing
dabico
reviewed
Apr 3, 2023
dabico
reviewed
Apr 3, 2023
dabico
reviewed
Apr 3, 2023
dabico
reviewed
Apr 3, 2023
dabico
reviewed
Apr 3, 2023
dabico
reviewed
Apr 3, 2023
dabico
reviewed
Apr 3, 2023
dabico
reviewed
Apr 3, 2023
dabico
reviewed
Apr 3, 2023
dabico
reviewed
Apr 3, 2023
dabico
reviewed
Apr 3, 2023
dabico
reviewed
Apr 3, 2023
dabico
reviewed
Apr 26, 2023
src/main/java/usi/si/seart/converter/GitRepoDtoToCsvConverter.java
Outdated
Show resolved
Hide resolved
|
There is a bug Im working on right now: |
dabico
reviewed
May 1, 2023
src/main/java/usi/si/seart/converter/GitRepoDtoToCsvConverter.java
Outdated
Show resolved
Hide resolved
dabico
reviewed
May 1, 2023
html/index.html
Outdated
Comment on lines
484
to
490
| <!-- <div class="col-12 col-md-6">--> | ||
| <!-- <div class="row">--> | ||
| <!-- <div class="col d-none d-md-flex justify-content-md-center">--> | ||
| <!-- <button class="btn btn-secondary border-dark border-5 w-50 mb-3">Search</button>--> | ||
| <!-- </div>--> | ||
| <!-- </div>--> | ||
| <!-- </div>--> |
There was a problem hiding this comment.
This is no longer needed remove it
dabico
reviewed
May 1, 2023
dabico
approved these changes
May 1, 2023
dabico
approved these changes
May 2, 2023
dabico
approved these changes
May 2, 2023
dabico
pushed a commit
that referenced
this pull request
Jun 21, 2023
- Metrics not getting stored Method GitRepoServiceImpl::createOrUpdateRepo was missing statements to copy over field values - Migration file V2 missing - Hikari pool size settings was missing
dabico
pushed a commit
that referenced
this pull request
Jun 21, 2023
Previously code analysis jobs were submitted with a GitRepo object in input, so as @dabico suggested it may have been an issue with the EntityManager having to cache 1.2M repository objects. Jobs now are submitted only along with the repo ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.