Schema normalization, model and service changes #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splits the old `repo_label` and `repo_language` tables from a many-to-one, into a many-to-many, while introducing the `label` and `language` tables. Note for labels: we no longer make a distinction between upper- and lower-case names, meaning that both `BUG`, `Bug` and `bug` are all treated as the latter in the DB.
For now, this only applies to: - `CrawlJob` - `GitRepo` - `SupportedLanguage` But I will gradually add the same principle to other entities as well.
This also includes naming changes for the columns, as well as the rewrite of `equals` and `hashCode`. The `GitRepo` entity now also uses `@ManyToMany` instead of `@OneToMany`.
dabico
force-pushed
the
enhancement/normalisation
branch
from
bde5506
to
037fa87
Compare
Will be used for `Topic`, `Language` and `Label`.
The biggest changes include the introduction of new services for each "many" class, as well as the decoupling of the same old methods from `GitRepoService`.
dabico
force-pushed
the
enhancement/normalisation
branch
from
037fa87
to
bee5013
Compare
dabico
changed the title
Closed
Don't use the online editor worst mistake of my fucking life
…isation # Conflicts: # src/main/java/usi/si/seart/model/Topic.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82