This repository has been archived by the owner on Sep 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- settings.yml has the same format as before - doi.yml, locales.yml and engines.yml are loaded before (the disabled attributes are removed) - if yaml search.engines path is defined, then all engines are disabled, and only engine specified in this list are enabled. - settings.yml contans only general, search, server, ui sections. The search section contains the enabled engines. - settings_robot.yml is unchanged
Some notes :
|
Add two new settings :
doi.yml, engines.yml, locales.yml are loaded directly into doi, engines, locales (not more prefix). Avoid to have settings about engines inside doi.yml for example. Note that the DOI settings have changed. Some bug fixes on oa_doi_rewrite. |
- search.include_engines_path : add engines definition (doesn't replace the content of engines.yml) doi.yml, engines.yml, locales.yml are loaded directly into doi, engines, locales (not more prefix) some bug fixes on oa_doi_rewrite
What do the core contributers think about this? I think this is a very smart idea all in all. |
Separating the engines part of the settings is a good idea, but the other files (languages, doi) aren't really necessary. What is the advantage of spreading the settings to multiple small files? |
Replaced by #2291 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #1209 :