Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

Implement #1209 #1278

Closed
wants to merge 2 commits into from
Closed

Implement #1209 #1278

wants to merge 2 commits into from

Conversation

dalf
Copy link
Contributor

@dalf dalf commented Apr 22, 2018

Implement #1209 :

  • settings.yml has the same format as before
  • doi.yml, locales.yml and engines.yml are loaded before (the disabled attributes are removed)
  • if yaml search.engines path is defined, then all engines are disabled, and only engine specified in this list are enabled.
  • settings.yml contans only general, search, server, ui sections. The search section contains the enabled engines.
  • settings_robot.yml is unchanged

- settings.yml has the same format as before
- doi.yml, locales.yml and engines.yml are loaded before (the disabled attributes are removed)
- if yaml search.engines path is defined, then all engines are disabled, and only engine specified in this list are enabled.
- settings.yml contans only general, search, server, ui sections. The search section contains the enabled engines.
- settings_robot.yml is unchanged
@dalf
Copy link
Contributor Author

dalf commented Apr 22, 2018

Some notes :

  • In this implementation an administrator can't define its own engine. I think that "search.engines_yaml" and "search.include_engines_yaml" should be added in settings.yml. The first one to replace engines.yml path, the second to add another engines.yml.
  • May be doi.yml, locales.yml, and engines.yml should be moved to the same directory than currencies.json and engines_languages.json ?

@dalf dalf requested a review from asciimoo April 22, 2018 14:41
@dalf
Copy link
Contributor Author

dalf commented Apr 22, 2018

Add two new settings :

  • search.engines_path : path of engines.yml
  • search.include_engines_path : additional engine definitions (doesn't replace the content of engines.yml)

doi.yml, engines.yml, locales.yml are loaded directly into doi, engines, locales (not more prefix). Avoid to have settings about engines inside doi.yml for example.

Note that the DOI settings have changed.

Some bug fixes on oa_doi_rewrite.

- search.include_engines_path : add engines definition (doesn't replace the content of engines.yml)

doi.yml, engines.yml, locales.yml are loaded directly into doi, engines, locales (not more prefix)
some bug fixes on oa_doi_rewrite
@jfowl
Copy link
Contributor

jfowl commented Feb 12, 2019

What do the core contributers think about this? I think this is a very smart idea all in all.

@asciimoo asciimoo added this to Milestone #2 - Backend in v1.0.0 Mar 4, 2020
@dalf dalf mentioned this pull request Oct 9, 2020
@asciimoo
Copy link
Member

Separating the engines part of the settings is a good idea, but the other files (languages, doi) aren't really necessary. What is the advantage of spreading the settings to multiple small files?

@dalf
Copy link
Contributor Author

dalf commented Nov 14, 2020

Replaced by #2291

@dalf dalf closed this Nov 14, 2020
v1.0.0 automation moved this from Milestone #2 - Backend to Done Nov 14, 2020
@dalf dalf deleted the settings branch April 27, 2021 06:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
v1.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants