Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

[fix] get YouTube results #1544

Merged
merged 2 commits into from Apr 9, 2019
Merged

[fix] get YouTube results #1544

merged 2 commits into from Apr 9, 2019

Conversation

MarcAbonce
Copy link
Contributor

Results are not appearing in the html document anymore, instead they are found inside an object embedded in a script.

Results are not appearing in the html document anymore,
instead they are found inside an object embedded in a script.
@MarcAbonce MarcAbonce changed the title [fix] get youtube results from js object [fix] get YouTube results Mar 27, 2019
@dalf dalf added the engine label Mar 27, 2019
@dalf
Copy link
Contributor

dalf commented Mar 28, 2019

Not sure if it is my setup, but I have two requests sent to youtube for one searx request :

DEBUG:urllib3.connectionpool:https://www.youtube.com:443 "GET /results?search_query=linux&page=1 HTTP/1.1" 200 None
DEBUG:urllib3.connectionpool:https://www.youtube.com:443 "GET /results?search_query=linux&page=1 HTTP/1.1" 200 None

@MarcAbonce
Copy link
Contributor Author

You're right. I just created #1545 as a separate PR because the issue is not really about the youtube engine, but rather with the way bangs are parsed.

@dalf dalf self-requested a review April 9, 2019 01:13
Copy link
Contributor

@dalf dalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@dalf dalf merged commit ca09d91 into searx:master Apr 9, 2019
@MarcAbonce MarcAbonce deleted the youtube_fix branch April 10, 2019 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants