[enh] every Sunday, call utils/fetch_*.py scripts and create a PR automatically #2500
Conversation
039ff36
to
7c36456
Compare
I have no experience with the git-workflows: If I merge this into the master of my fork (return42/searx) on github .. will it also create PRs on my my fork? .. I guess .. if so .. can we set a condition in the git-workflow, that the workflow is active only on repository searx/searx? |
7c36456
to
3330cf4
Compare
I have updated the PR: the workflow will return only if the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ..
OT: just a question of mine
DATA_PR_TOKEN is a personal access tokens.
Tried to find, where I can set it using https://docs.github.com/en/github/developing-online-with-codespaces/managing-encrypted-secrets-for-codespaces .. but cant find 'Codespaces' what is documented there ... do I need a special contract to set such tokens?
To get the token: your profile, Settings, Developer settings tab, Personal access tokens tab. |
Dump question, is this git-workflow inactive? When I modified searx/data/useragents.json
@@ -1,8 +1,10 @@
{
"versions": [
+ "85.0.1",
+ "85.0",
+ "84.0.2",
"84.0.1",
- "84.0",
- "83.0"
+ "84.0"
],
"os": [
"Windows NT 10.0; WOW64", What I mean; I can't see that this PR does anything .. I'm wrong? .. Is there a place, where can we monitor the tasks from searx/.github/workflows/data-update.yml Lines 3 to 4 in ab87398
I guess the notation is what we know from unix cron entries.. right? |
It fails yesterday: https://github.com/searx/searx/actions/runs/545400665 This line searx/.github/workflows/data-update.yml Line 10 in ab87398
should be if: secrets.DATA_PR_TOKEN != null
|
I see! ... thanks for the link .. I should have more time to learn more about git-workflows.
If you have time do you like to fix it .. now I see that is already used here searx/.github/workflows/data-update.yml Line 50 in ab87398
|
Seems that |
What does this PR do?
Use https://github.com/peter-evans/create-pull-request to create a PR when there is data update.
data in https://github.com/searx/searx/tree/master/searx/data
Example PR :
utils/fetch_languages.py
update (second commit of this PR) : engines_languages.json and languages.json are committed in the wrong place.This PR also makes a minor update of
utils/fetch_languages.py
.Why is this change important?
See #2052 (comment)
How to test this PR locally?
N/A
Author's checklist
Related issues
See #2052