Add Docker Hub search engine. #2543
Conversation
| @@ -26,3 +26,5 @@ dist/ | |||
| local/ | |||
| gh-pages/ | |||
| searx.egg-info/ | |||
|
|
|||
| .vscode/ | |||
There was a problem hiding this comment.
Please do not add any editor specific line to this file.
There was a problem hiding this comment.
OK. How do you suggest I stop my config from being pushed without manually staging each of my commits?
There was a problem hiding this comment.
without manually staging each of my commits?
what should that tell me?!? Please learn git and SCM basics .. to me it seems you won't learn for what all this is good.
There was a problem hiding this comment.
How do you suggest I stop my config from being pushed without manually staging each of my commits?
See https://stackoverflow.com/questions/5724455/can-i-make-a-user-specific-gitignore-file
| @results JSON | ||
| @stable yes | ||
| @parse url, title, content, thumbnail, publishedDate | ||
| """ |
There was a problem hiding this comment.
Please use 'about' notation / like any other engine does, here is an example from the google engine:
Lines 22 to 29 in ab87398
There was a problem hiding this comment.
The wikidata_id is Q100769064 : https://www.wikidata.org/wiki/Q100769064
| '''pre-request callback | ||
| params<dict>: | ||
| method : POST/GET | ||
| headers : {} | ||
| data : {} # if method == POST | ||
| url : '' | ||
| category: 'search category' | ||
| pageno : 1 # number of the requested page | ||
| ''' |
There was a problem hiding this comment.
I guess these doc-strings can be dropped .. if there is something special to this engine, it is good to write down a doc-string, but if it is only C&P better leaf it.
|
@SuperSonicHub1 thanks a lot for another engine!! ..I really like your contributions, but there is one thing that disturbs me: it is the commit history. In the master branch we want to avoid a cluttered history. It is very hard to maintain code if the history is cluttered. Can you please squash your commits to one and have one clear commit message / thanks! In #2429 (comment) I gave you some links about git-workflows at hand. I guess the cluttered commit series is also one reason why #2429 hangs at the moment. |
|
Hello, Thank you for your contribution. Could you squash your commits to a single commit? |
|
@SuperSonicHub1 see my comment at : #2429 (comment) |
Slightly modified merge of commit [1cb1d3ac] from searx [PR 2543]:
This adds Docker Hub .. as a search engine .. the engine's favicon was
downloaded from the Docker Hub website with wget and converted to a PNG
with ImageMagick .. It supports the parsing of URLs, titles, content,
published dates, and thumbnails of Docker images.
[1cb1d3ac] searx/searx@1cb1d3ac
[PR 2543] searx/searx#2543
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
What does this PR do?
This adds Docker Hub to Searx as a search engine and resolves issue #2433. I modeled this engine around the existing SoundCloud engine, the engine's favicon was downloaded from the Docker Hub website with
wgetand converted to a PNG with ImageMagick, and the shortcut was plucked from DDG's bangs database. It supports the parsing of URLs, titles, content, published dates, and thumbnails of Docker images.Why is this change important?
Once again, I wanted to resolve issue #2433. As a semi-regular user of the Hub myself, I'm sure many developers would find the direct ability to search for Docker images very convenient.
How to test this PR locally?
This PR is fully compatible with
make test. To see it in action:make run!dockerhub searxRelated issues
Closes #2433