Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

Added rumble.com video search engine. #2588

Merged
merged 1 commit into from Feb 21, 2021
Merged

Added rumble.com video search engine. #2588

merged 1 commit into from Feb 21, 2021

Conversation

datagram1
Copy link
Contributor

New video search engine: rumble.com
Added rumble.py to searx/engines/
Add rumble.com to sears/settings.yml -1254
Same style + xpath processing using lxml as other engines.
No changes anywhere else.

@unixfox
Copy link
Member

unixfox commented Feb 19, 2021

Please disable the engine by default and fix the checks

@return42
Copy link
Contributor

make test.pep8 fails: https://github.com/searx/searx/pull/2588/checks?check_run_id=1936565783#step:7:36

Before send PR please run

 make test

Have a look at quickstart guide more info available at How to contribute

@datagram1
Copy link
Contributor Author

looks good now

@unixfox
Copy link
Member

unixfox commented Feb 19, 2021

Please squash your commits into one.

Update rumble.py

some lines too long.

Disable Rumble engine

disabled : True

PEP8 fix

change line spacing
@datagram1
Copy link
Contributor Author

commits squashed into 1

@dalf dalf merged commit 9ace31c into searx:master Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants