This repository has been archived by the owner on Sep 7, 2023. It is now read-only.
[enh] oscar: image thumbnail layout #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return42
previously approved these changes
Mar 22, 2021
dalf
commented
Mar 23, 2021
| if (isSearching) { | ||
| this._setSize(slice, Math.min(this.maxHeight, h)); | ||
| break; | ||
| } |
There was a problem hiding this comment.
continue w is replaced by isSearching : try to make the code more readable.
dalf
commented
Mar 23, 2021
| .result-images a:focus .img-thumbnail { | ||
| box-shadow: 5px 5px 15px 0px black; | ||
| } | ||
| .result-images.js a .img-thumbnail { |
There was a problem hiding this comment.
ImageLayout adds the js class for each processed image.
kvch
previously approved these changes
Apr 3, 2021
Adjust thumbnail sizes to fill the container width
BBaoVanC
approved these changes
Apr 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With javascript
Without javascript
Why is this change important?
Improve UX.
How to test this PR locally?
use the different oscar styles, search for
!images time!general !images timeTry javascript enable and disabled.
Author's checklist
Related issues