This repository has been archived by the owner on Sep 7, 2023. It is now read-only.
Add new engine: SJP - Słownik języka polskiego #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
reviewed
Apr 9, 2021
searx/engines/sjp.py
Outdated
|
|
||
| raise_for_httperror(resp) | ||
| dom = fromstring(resp.text) | ||
| word = extract_text(dom.xpath('//*[@id="content"]/div/div[1]/div/div[1]/div[1]/div[2]/div/div/div[2]/div/div')) |
There was a problem hiding this comment.
Do you mind simplifying the XPATH expressions in the PR?
The page you are scraping is indeed very messy, but it would be nice to use simpler expressions so we could minimize the chance of this engine breaking if the page gets redesigned.
For starters, I think this line could be simplified to
word = extract_text(dom.xpath('//div[@class="query"]'))I have started to simplify the other expressions, but it is a bit hard as I do not speak Polish (besides "polak, wegier, dwa bratanki // i do szabli, i do szklanki" :D :D :D) so I have no idea if I am selecting the right parts of the page.
There was a problem hiding this comment.
Good advice @kvch.
Well, I can only say "egészségedre!" in your language. Probably the most important "do szklanki" :-)
kvch
suggested changes
Apr 9, 2021
kvch
approved these changes
Apr 16, 2021
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new search engine: SJP - Słownik języka polskiego (The Great Dictionary of Polish).
The engine aggregates three major dictionaries of Polish language:
The engine presents responses in the
infobox.Why is this change important?
At the moment Searx is missing the engines allowing users to improve their vocabulary. I am trying to patch this gap with wordnik.com for English language (already in PR: 2735) and now with SJP for Polish.
How to test this PR locally?
Run
make runand search eg.!sjp słownik.