Skip to content

Commit

Permalink
[fix] ddg engines (get_vqd) - the vqd value is no longer in the form
Browse files Browse the repository at this point in the history
Closes: #3276
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
  • Loading branch information
return42 committed Mar 5, 2024
1 parent b7be53b commit d97b84b
Showing 1 changed file with 14 additions and 24 deletions.
38 changes: 14 additions & 24 deletions searx/engines/duckduckgo.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def cache_vqd(query, value):
c = redisdb.client()
if c:
logger.debug("cache vqd value: %s", value)
key = 'SearXNG_ddg_vqd' + redislib.secret_hash(query)
key = 'SearXNG_ddg_web_vqd' + redislib.secret_hash(query)
c.set(key, value, ex=600)


Expand Down Expand Up @@ -105,27 +105,25 @@ def get_vqd(query):
- DuckDuckGo News: ``https://duckduckgo.com/news.js??q=...&vqd=...``
"""
value = ''
value = None
c = redisdb.client()
if c:
key = 'SearXNG_ddg_vqd' + redislib.secret_hash(query)
key = 'SearXNG_ddg_web_vqd' + redislib.secret_hash(query)
value = c.get(key)
if value or value == b'':
value = value.decode('utf-8')
logger.debug("re-use cached vqd value: %s", value)
return value

query_url = 'https://lite.duckduckgo.com/lite/?{args}'.format(args=urlencode({'q': query}))
query_url = 'https://duckduckgo.com/?' + urlencode({'q': query})
res = get(query_url)
doc = lxml.html.fromstring(res.text)
value = doc.xpath("//input[@name='vqd']/@value")
if value:
value = value[0]
else:
# Some search terms do not have results and therefore no vqd value. If
# no vqd value can be determined for the search term, an empty string is
# chached.
value = ''
for script in doc.xpath("//script[@type='text/javascript']"):
script = script.text
if 'vqd="' in script:
value = script[script.index('vqd="') + 5 :]
value = value[: value.index('"')]
break
logger.debug("new vqd value: '%s'", value)
cache_vqd(query, value)
return value
Expand Down Expand Up @@ -228,10 +226,6 @@ def request(query, params):

# request needs a vqd argument
vqd = get_vqd(query)
if not vqd:
# some search terms do not have results and therefore no vqd value
params['url'] = None
return params

# quote ddg bangs
query_parts = []
Expand Down Expand Up @@ -260,14 +254,14 @@ def request(query, params):

# initial page does not have an offset
if params['pageno'] == 2:
# second page does have an offset of 30
offset = (params['pageno'] - 1) * 30
# second page does have an offset of 20
offset = (params['pageno'] - 1) * 20
params['data']['s'] = offset
params['data']['dc'] = offset + 1

elif params['pageno'] > 2:
# third and following pages do have an offset of 30 + n*50
offset = 30 + (params['pageno'] - 2) * 50
# third and following pages do have an offset of 20 + n*50
offset = 20 + (params['pageno'] - 2) * 50
params['data']['s'] = offset
params['data']['dc'] = offset + 1

Expand Down Expand Up @@ -322,10 +316,6 @@ def response(resp):
form_data['o'] = eval_xpath(form, '//input[@name="o"]/@value')[0]
logger.debug('form_data: %s', form_data)

value = eval_xpath(form, '//input[@name="vqd"]/@value')[0]
query = resp.search_params['data']['q']
cache_vqd(query, value)

tr_rows = eval_xpath(result_table, './/tr')
# In the last <tr> is the form of the 'previous/next page' links
tr_rows = tr_rows[:-1]
Expand Down

0 comments on commit d97b84b

Please sign in to comment.