-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static files: move source to a dedicated directory. #141
Comments
For the first step we should leave the static build products where they are and move only the source files of the build products to another location
Hm, why not BTW: what about the files in
If there comes the day we think it is a good idea, we can also move |
👍 There are files that are not compiled:
I'm not sure what to do for these files. |
Leave them where they are .. in a second step, we can have a look what files can be generated ... E.g.
|
@dafl are you implementing the move to |
I will do it. |
In #151 we have moved source files to the The next step should be to move the Moving the source files includes moving the
@dalf should I give it a try / I assume that you know more about this topic but if you do not have time, I could give it a try (might be a good exercise for me). |
Include the source files directly in the `.map` files [1] for two reasons: 1. In the simple theme, modules from `./node_modules` are only available on developer's build host (a `make node.env` is needed to get the sources). By example; in the `searxng.min.js.map` file, the `autocomplete.js` is linked at URL: ../node_modules/autocomplete-js/dist/autocomplete.js 2. Later, when client sources has been moved out of the `./static` URL [2] to the `<repo-roo>/src` folder, all JS sources are no longer available. Drawback: `.map` files grow up in size, but this should not bother, because the files are only loaded in debug mode. [1] https://github.com/gruntjs/grunt-contrib-uglify#sourcemapincludesources [2] searxng#141 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Include the source files directly in the `.map` files [1] for two reasons: 1. In the simple theme, modules from `./node_modules` are only available on developer's build host (a `make node.env` is needed to get the sources). By example; in the `searxng.min.js.map` file, the `autocomplete.js` is linked at URL: ../node_modules/autocomplete-js/dist/autocomplete.js 2. Later, when client sources has been moved out of the `./static` URL [2] to the `<repo-roo>/src` folder, all JS sources are no longer available. Drawback: `.map` files grow up in size, but this should not bother, because the files are only loaded in debug mode. [1] https://github.com/gruntjs/grunt-contrib-uglify#sourcemapincludesources [2] searxng#141 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Include the source files directly in the `.map` files [1] for two reasons: 1. In the simple theme, modules from `./node_modules` are only available on developer's build host (a `make node.env` is needed to get the sources). By example; in the `searxng.min.js.map` file, the `autocomplete.js` is linked at URL: ../node_modules/autocomplete-js/dist/autocomplete.js 2. Later, when client sources has been moved out of the `./static` URL [2] to the `<repo-roo>/src` folder, all JS sources are no longer available. Drawback: `.map` files grow up in size, but this should not bother, because the files are only loaded in debug mode. [1] https://github.com/gruntjs/grunt-contrib-uglify#sourcemapincludesources [2] searxng#141 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Since it is a topic in itself, here a new issue :
From #137 (comment)
I would see:
But a lot of stuff expect searx source code in the
searx
directory.So If the source folder for the static files is
static/src
or juststatic
.The text was updated successfully, but these errors were encountered: