Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manage / Makefile: PYLINT_FILES PR conflicts #21

Closed
dalf opened this issue Apr 23, 2021 · 0 comments · Fixed by #31
Closed

manage / Makefile: PYLINT_FILES PR conflicts #21

dalf opened this issue Apr 23, 2021 · 0 comments · Fixed by #31
Labels
poc Prove of concept

Comments

@dalf
Copy link
Member

dalf commented Apr 23, 2021 •
edited

The PYLINT_FILES variable conflicts when it is modified:

  • a PR based on a master commit
  • the PR changes PYLINT_FILES
  • a new commit on master changes PYLINT_FILES
  • now there is a conflict

Would it make sense

  • to flag files with a tag inside their contents. For example # manage: enable=pylint
  • then git grep can find them.
    ?

So

PYLINT_TRIGGER = "# manage: enable=pylint"
PYLINT_FILES = $(grep -l -r --include \*.py "${PYLINT_TRIGGER}" searx searx_utils)

could replace

searxng/manage

Lines 22 to 44 in 0603b04

PYLINT_FILES=(
searx/preferences.py
searx/testing.py
searx/engines/gigablast.py
searx/engines/deviantart.py
searx/engines/digg.py
searx/engines/google.py
searx/engines/google_news.py
searx/engines/google_videos.py
searx/engines/google_images.py
searx/engines/mediathekviewweb.py
searx/engines/meilisearch.py
searx/engines/solidtorrents.py
searx/engines/solr.py
searx/engines/springer.py
searx/engines/google_scholar.py
searx/engines/yahoo_news.py
searx/engines/apkmirror.py
searx/engines/artic.py
searx/engines/core.py
searx_extra/update/update_external_bangs.py
searx/metrics/__init__.py
)

@return42 return42 added the poc Prove of concept label Apr 25, 2021
return42 added a commit to return42/searxng that referenced this issue Apr 26, 2021
@return42
[mod] get PYLINT_FILES from tag '# lint: pylint'
33f58b3 
These py files are linted by test.pylint(), all other files are linted by
test.pep8()

Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Closes: searxng#21
return42 added a commit to return42/searxng that referenced this issue Apr 26, 2021
@return42
[mod] get PYLINT_FILES from tag '# lint: pylint'
65a58c3 
These py files are linted by test.pylint(), all other files are linted by
test.pep8()

close: searxng#21
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42 added a commit to return42/searxng that referenced this issue Apr 26, 2021
@return42
[pylint] get PYLINT_FILES from tag '# lint: pylint'
a92a4cb 
These py files are linted by test.pylint(), all other files are linted by
test.pep8()

close: searxng#21
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
@return42 return42 mentioned this issue Apr 26, 2021
Merged
@dalf dalf closed this as completed in #31 Apr 26, 2021
@Lalarian Lalarian mentioned this issue Jul 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
poc Prove of concept
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pylint] get PYLINT_FILES from tag '# lint: pylint' return42/searxng
2 participants
@return42 @dalf