-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: wikicommons.images #2707
Labels
bug
Something isn't working
Comments
return42
added a commit
to return42/searxng
that referenced
this issue
Sep 3, 2023
From [1]: It seems to be because of [2] For some reason it gets url encoded twice, resulting in - ``filetype%253Abitmap%257Cdrawing+birds`` instead of - ``filetype:bitmap%7Cdrawing+birds`` [1] searxng#2707 [2] https://github.com/searxng/searxng/blob/master/searx/engines/wikicommons.py#L43 Closes: searxng#2707 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
@bonswouar thanks for early testing and your deep analysis, which was very helpful to me 👍 .. seems we should better not url-quote |
return42
added a commit
that referenced
this issue
Sep 3, 2023
From [1]: It seems to be because of [2] For some reason it gets url encoded twice, resulting in - ``filetype%253Abitmap%257Cdrawing+birds`` instead of - ``filetype:bitmap%7Cdrawing+birds`` [1] #2707 [2] https://github.com/searxng/searxng/blob/master/searx/engines/wikicommons.py#L43 Closes: #2707 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version of SearXNG, commit number if you are using on master branch and stipulate if you forked SearXNG
2023.9.2+4f8895c6d
How did you install SearXNG?
Docker from official wiki
What happened?
I always get 0 result with wikicommons images (but no error)
How To Reproduce
!wc birds
Expected behavior
Should return results
Screenshots & Logs
Additional context
It seems to be because of https://github.com/searxng/searxng/blob/master/searx/engines/wikicommons.py#L43
For some reason it gets url encoded twice, resulting in
filetype%253Abitmap%257Cdrawing+birds
instead offiletype%3Abitmap%7Cdrawing+birds
(see logs)The text was updated successfully, but these errors were encountered: