[BUG] Images cannot be clicked anymore

[WreckingBANG]

Version of SearXNG, commit number if you are using on master branch and stipulate if you forked SearXNG
2023.11.12-6368f845c

How did you install SearXNG?
docker-compose

What happened?
When i click on any image from any search engine, there should appear a section showing the image in a bigger size with the options to open the website it is from and other option. This section is not appearing anymore.

How To Reproduce

1. Search Anything
2. Click on any Image
3. Nothing happens (No section is opening)

Expected behavior
There should appear a section showing the image in a bigger size with the options to open the website it is from and other option.

Screenshots & Logs
@@

I marked the Section that is now missing red

Additional context
I tested it on my own private instance as well as on https://search.inetol.net . Both instances showed the same behaviour.
I tested it on Chromium and Firefox .
I tested it on Mobile (Android) and Desktop (Linux).
I tried clearing my Browser Cache.
It seems to be since 2023.11.11-7b1951aa9

[return42]

Not sure but it seems the JS is broken on https://search.inetol.net

I tested with 2023.11.12+76b91a3ef (current master) and it works and I tested some instances from searx.space and version 2023.11.11 .. no issues.

Did you customized CSS or JS?

[unixfox]

Can't replicate either on https://paulgo.io/

On searx.space, for search.inetol.net it says the instance is customized.

[WreckingBANG]

I did not customize my css, i will check for errors on my instance tomorrow

[WreckingBANG2]

https://search.sapti.me does not use custom css and has the same error.

[return42]

I guess the initialization fails due to this exception, when the page is loaded.

This line raises the error ..

searxng/searx/static/themes/simple/src/js/main/results.js

Line 19 in 76b91a3

d.querySelector('#search_url button#copy_url').style.display = "block";

But I do not understand why / and why it works in current master but not on some of the instances.

[BernieHuang2008]

According to the error message, it seems that the script is loaded before HTML, but I'm not sure, and this can't explain why it failed sometimes.

[return42]

According to the error message, it seems that the script is loaded before HTML, but I'm not sure, and this can't explain why it failed sometimes.

The HTML loads the CSS and then JS .. but for some reasons the instances with this issue miss the button in the sidebar:

searxng/searx/templates/simple/elements/search_url.html

Line 4 in 76b91a3

<button id="copy_url" type="submit" data-copied-text="{{ _('Copied') }}">{{ _('Copy') }}</button>

Aah .. here is the reason .. URL is only shown in HTTP POST request:

searxng/searx/templates/simple/results.html

Lines 56 to 58 in 76b91a3

	{%- if method == 'POST' -%}
	{%- include 'simple/elements/search_url.html' -%}
	{%- endif -%}

When set to GET ..

searxng/searx/settings.yml

Line 89 in 76b91a3

method: "POST"

there is no URL in the sidebar!
@BernieHuang2008 can you please fix it (here):

searxng/searx/static/themes/simple/src/js/main/results.js

Line 19 in 76b91a3

d.querySelector('#search_url button#copy_url').style.display = "block";

[extremelyonline]

Hello, I encountered a similar issue but only on the mobile site. In my testing, the image click doens't work on:

priv.au
search.inetol.net
paulgo.io 
opnxng.com

However, it works on:

331221.xyz
searx.be

I did my testing on Android Cromite, with ad block and incognito mode disabled.

[BernieHuang2008]

@return42

I apologize for my mistake, now it's solved in #3006, please have a look ~

[return42]

I apologize for my mistake,

no need to apologize .. its a complex thing .. don't ask how many mistakes I do every day ;)

[WreckingBANG]

Thank you for fixing it that quickly!👍