Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"!ddg !g something" returns no result / same to "!brave !g something" (brave XPath engine) #392

Open
dalf opened this issue Oct 7, 2021 · 5 comments · Fixed by #2309
Open
Labels
area: engine bug Something isn't working

Comments

@dalf
Copy link
Member

dalf commented Oct 7, 2021

What is happening?

  • !ddg is a bang that selects the duckduckgo engine.
  • !g is NOT a bang: it is send as part of the query

--> "!ddg !g something" search for "!g something" on duckduckgo
--> DDG redirects to google with the search "something"
--> SearXNG can't parse the result (and record an unexpected redirect)

The same things happens with the Brave engine ( !brave !g something)

What is expected?

Search for !g something without the following the DDG bang.
It seems it is possible with quote: "!g" something.

If this solution is not reliable:

  • at least display a warning to the user
  • display a warning in the autocompletion
@dalf dalf added the bug Something isn't working label Oct 7, 2021
@allendema
Copy link
Contributor

The same applies to Brave engine (They seem to use the same bangs as DDG)

!brave !g something

@not-my-profile
Copy link
Contributor

The warning displayed to the user should suggest our external bang syntax e.g. attempting !ddg !g should suggest !!g.

return42 added a commit to return42/searxng that referenced this issue Apr 3, 2023
Closes: searxng#392
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
@dalf
Copy link
Member Author

dalf commented Apr 3, 2023

if still valid, brave has the same issue : #392 (comment)

@return42
Copy link
Member

return42 commented Apr 3, 2023

Sorry I merged my PR accidental .. without asking for a review .. (see my comment on matrix) .. we can reopen this issue, but if it is OK, I prefer to handle the brave issue in #2294.

@dalf
Copy link
Member Author

dalf commented Apr 3, 2023

You may want to keep the issue open, that's just what I was saying.

@return42 return42 reopened this Apr 3, 2023
@return42 return42 changed the title "!ddg !g something" returns no result "!ddg !g something" returns no result / same to "!brave !g something" (brave XPath engine) May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: engine bug Something isn't working
Projects
Status: Discussion
Development

Successfully merging a pull request may close this issue.

4 participants