Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwanted suggestions when a currency conversion is made with Google #442

Closed
ghost opened this issue Oct 27, 2021 · 2 comments · Fixed by #547
Closed

Unwanted suggestions when a currency conversion is made with Google #442

ghost opened this issue Oct 27, 2021 · 2 comments · Fixed by #547
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Oct 27, 2021 •
edited by ghost

Version of SearXNG, commit number if you are using on master branch and stipulate if you forked SearXNG

  • 1.0.0-948-cec9ded2, master branch, not forked

How did you install SearXNG?

  • searxng-docker

What happened?

  • "Disclaimer" and "Data provided by Morningstar for Currency and Coinbase for Cryptocurrency" are being added to search suggestions when they should not be there.

How To Reproduce

  • Do a currency conversion with Google enabled.
  • Examples:
    • 10 usd to cad
    • 1 btc to usd

Expected behavior

  • Suggestions circled in red below are not suggestions and not should be there.

Screenshots & Logs

image
@ghost ghost added the bug Something isn't working label Oct 27, 2021
@dalf
Copy link
Member

dalf commented Oct 27, 2021

The suggestions comes from the google engine: !google 10 usd to cad

@ghost ghost changed the title Unwanted suggestions when a currency conversion is made with Yahoo Unwanted suggestions when a currency conversion is made with Google Oct 27, 2021
return42 added a commit to return42/searxng that referenced this issue Nov 25, 2021
@return42
[fix] google engine - suggestion
488ace1 
BTW: google no longer offers *spelling suggestions*

Closes: searxng#442
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
@return42 return42 mentioned this issue Nov 26, 2021
Merged
@return42
Copy link
Member

Hi @pyvon thanks for your report .. the google & google-videos engine need a rework, I fixed the issues in #547 / can you test the PR / thanks!

@dalf dalf closed this as completed in #547 Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] google & google video engines return42/searxng
2 participants
@return42 @dalf