Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTL Layout] Don't flip Music ♫ category icon #770

Closed
GreenLunar opened this issue Jan 17, 2022 · 5 comments
Closed

[RTL Layout] Don't flip Music ♫ category icon #770

GreenLunar opened this issue Jan 17, 2022 · 5 comments
Labels
area: simple theme bug Something isn't working

Comments

@GreenLunar
Copy link
Contributor

Using CSS transform: scaleX(-1);
Sorry for not committing a PR, and I have no good excuse for not doing so.

@mrpaulblack
Copy link
Member

All inlined icons are already flipped in RTL since the RTL PR.

Its done here:

And the flip is defined here for RTL:

.ltr-transform() {
transform: scale(-1, 1);
}

Closing; Feel free to reopen if you meant something else or you think this could be improved...

@GreenLunar
Copy link
Contributor Author

GreenLunar commented Jan 17, 2022

Thanks. I've changed the subject.
Looking at the screenshot of #750, we should make an exception for the sign of ♫ Music category.

@GreenLunar GreenLunar changed the title [RTL Layout] Flip action & category icons [RTL Layout] Don't Music flip ♫ category icon Jan 17, 2022
@mrpaulblack mrpaulblack reopened this Jan 17, 2022
@GreenLunar GreenLunar changed the title [RTL Layout] Don't Music flip ♫ category icon [RTL Layout] Don't flip Music ♫ category icon Jan 17, 2022
@mrpaulblack mrpaulblack added the bug Something isn't working label May 14, 2022
@return42
Copy link
Member

return42 commented Apr 3, 2023

@GreenLunar I fully understand your requirement, but to meet it would mean that we would have to consider each (possible) sign (symbol) separately.

This would make the implementation more complex and the effort in relation to the benefit is not justified compared to other requirements that are more urgent.

I ask for your understanding that we will not comply with this request and close the issue.

@return42 return42 closed this as completed Apr 3, 2023
@GreenLunar
Copy link
Contributor Author

GreenLunar commented Apr 4, 2023 via email

@return42
Copy link
Member

return42 commented Apr 5, 2023

Would you accept a pull request if I would send any?

Depends on the implementation. A PR is a concrete object on which to discuss. Perhaps there is a simple implementation ...

PRs are always welcome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: simple theme bug Something isn't working
Projects
Status: Closed
Development

No branches or pull requests

4 participants