Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] docker generated new settings.yml does not contain instance_name/base_url of the commandline #876

Closed
neiaberau opened this issue Feb 6, 2022 · 1 comment · Fixed by #877
Labels
bug Something isn't working question Further information is requested

Comments

@neiaberau
Copy link

I stated this as question as I do not know whether this is supposed to happen, but when I start
docker run -d --name=test -p 8898:8080 -v "${PWD}/test:/etc/searxng" -e INSTANCE_NAME=test searxng/searxng

the settings.yml does not contain the instance_name (or base_url) settings as supplied on the line above, which I would have expected as with searx/searx this is done.

after some digging I came to the conclusion that commit
[yamllint] searx/settings.yml 5a7b12e
changed the yml formating, and the sed expressions in docker_entrypoint.sh do no longer match and therefore do not replace the content anymore

I guess settings.yml or docker_entrypoint.sh should be changed to match again

@neiaberau neiaberau added the question Further information is requested label Feb 6, 2022
@return42 return42 added the bug Something isn't working label Feb 6, 2022
return42 added a commit to return42/searxng that referenced this issue Feb 6, 2022
In commit 5a7b12e we normalized settings.yml and c6a5cc0 and de5a8ee we
changed instance name to ``instance_name: "SearXNG"``.

This patch adjust the sed expressions to modify:

    dockerfiles/docker-entrypoint.sh

Closes: searxng#876
Suggested-by:  @neiaberau
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
@return42
Copy link
Member

return42 commented Feb 6, 2022

@neiaberau: thanks a lot for your deep analysis! .. I tried to fix the issue in #877.

@dalf dalf closed this as completed in #877 Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants