Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG ?] Images on search engine are mostly small. #909

Closed
Shituation opened this issue Feb 18, 2022 · 4 comments · Fixed by #910
Closed

[BUG ?] Images on search engine are mostly small. #909

Shituation opened this issue Feb 18, 2022 · 4 comments · Fixed by #910
Labels
bug Something isn't working

Comments

@Shituation
Copy link

Using searx.be public instance.
Images returned on the search image category are too small. Like really too small. No sizes on thumbnails option makes this worse, so the image search is unusable right now.

How To Reproduce
Search for images of whatever topic.

Expected behavior
To see a range of sizes, mostly medium, upwards. Also a filter for sizes would be cool.

@Shituation Shituation added the bug Something isn't working label Feb 18, 2022
@tiekoetter
Copy link
Member

Could you give an example URL or Screenshot?

@Shituation
Copy link
Author

Shituation commented Feb 18, 2022

On the search:
image

After opening:
image

Following "Source"
image

@tiekoetter
Copy link
Member

This seems to depend on which engine is used.

Example: Google Images
https://searx.tiekoetter.com/search?q=%21goi+land+%3Aen_us

Example: Bing Images
https://searx.tiekoetter.com/search?q=%21bii+land+%3Aen_us

I will take a look if there is an option to get a different size from google images.

tiekoetter added a commit to tiekoetter/searxng that referenced this issue Feb 18, 2022
The 'scrap_img_by_id' function didn't return anything useful. This fix allows the google images engine to present the full source image instead of only the thumbnail.

Closes: searxng#909
tiekoetter added a commit to tiekoetter/searxng that referenced this issue Feb 18, 2022
The 'scrap_img_by_id' function didn't return anything useful. This fix allows the google images engine to present the full source image instead of only the thumbnail.

Closes: searxng#909
tiekoetter added a commit to tiekoetter/searxng that referenced this issue Feb 19, 2022
The 'scrap_img_by_id' function didn't return anything useful. This fix allows the google images engine to present the full source image instead of only the thumbnail.

Closes: searxng#909
return42 added a commit to return42/searxng that referenced this issue Feb 19, 2022
The 'scrap_img_by_id' function didn't return any longer anything useful.  This
fix allows the google images engine to present the full source image instead of
only the thumbnail.

The function scrap_img_by_id() is rpelaced by a fully rewrite to parse image
URLs by a regular expression. The new function parse_urls_img_from_js(dom)
returns a mapping of data-id to image URL.

Closes: searxng#909
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42 added a commit to return42/searxng that referenced this issue Feb 19, 2022
The 'scrap_img_by_id' function didn't return any longer anything useful.  This
fix allows the google images engine to present the full source image instead of
only the thumbnail.

The function scrap_img_by_id() is rpelaced by a fully rewrite to parse image
URLs by a regular expression. The new function parse_urls_img_from_js(dom)
returns a mapping of data-id to image URL.

Closes: searxng#909
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
@dalf
Copy link
Member

dalf commented Feb 20, 2022

Related to #898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants