Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

. #928

Closed
throwaway26425 opened this issue Feb 27, 2022 · 13 comments
Closed

. #928

throwaway26425 opened this issue Feb 27, 2022 · 13 comments
Labels
area: simple theme bug Something isn't working

Comments

@throwaway26425
Copy link

throwaway26425 commented Feb 27, 2022

No description provided.

@dalf dalf added area: simple theme bug Something isn't working labels Feb 27, 2022
dalf added a commit to dalf/searxng that referenced this issue Feb 27, 2022
@dalf
Copy link
Member

dalf commented Feb 27, 2022

Thank you for the detail report, it is really helpful. We want to drop the Oscar theme to maintain only one theme ;
but the issues you are reporting are all valid, so the idea is fix the Simple theme.

the 'Clear' button of the Simple theme doesn't seem to do anything with JS disabled.

it is going to be fixed with #894 (commit 6352496)

On mobile (with JS disabled).

Currently when Javascript is enabled:

Simple Oscar
image image

... I see that it can works without javascript (need some tests).
So a pull request is going to fix that (see #929 )

On desktop.

What is your screen resolution?
It is seems related to #874

Can you try to set the zoom at 90%?

dalf added a commit to dalf/searxng that referenced this issue Feb 27, 2022
dalf added a commit to dalf/searxng that referenced this issue Feb 27, 2022
@GreenLunar
Copy link
Contributor

Simple is much nicer, especially for people not liking JS, IMHO. See Image results as an example for it.
I suggest to keep Simple as default and fix it where Oscar does better and wherever else needed.

@GreenLunar
Copy link
Contributor

Proposed fixes:

Desktop
sshot-2022-02-26-19-04-49

Place suggestions in a single column to the left.

On mobile (with JS disabled)
screen_20220226-190638

Place categories in a single row.
Keep suggestions untouched.

@GreenLunar
Copy link
Contributor

I see what the problems are when JS is disabled and when using mobile interface.
Fix the Simple theme, don't replace it. Simple theme is one of the few the,es (I guess 2), that work properly with and without JS. Oscar must have JS enabled to work properly, especialy in image search.

@dalf
Copy link
Member

dalf commented Mar 4, 2022

@worthless133 on desktop, can you try to set the zoom at 90%? The issue seems related to #874 , and there is a fix for this issue.

@dalf
Copy link
Member

dalf commented Mar 4, 2022

What is your screen resolution?

@dalf
Copy link
Member

dalf commented Mar 4, 2022

Thank for the information.

Currently the layout switches to the desktop layout according to the screen width:

  • above 1280px, the layout is for desktop (suggestion on the right side)
  • equal or below 1280px, the layout is for tablet (suggestion above the result)

But there are other way to detect a tablet, however it requires some other changes to fit screen widths below 1280px.


In meantime, do you use a public instance? or your own instance?

If you use your own instance, you can use this settings.yml file:

use_default_settings: true  # inherit from the default settings.yml
server:
  default_theme: oscar  # but override the default theme

@dalf
Copy link
Member

dalf commented Mar 4, 2022

when I set the zoom at 67% is when I start seeing the suggestions on the right side XDDD

👍

It is not documented, so it's hard to guess. It can be discover by resizing the window ... if the screen resolution allows it.

@GreenLunar
Copy link
Contributor

I use public instances, so I can't change that:(

You can, use Greasemonkey or Tampermonkey to make arbitrary changes.

@throwaway26425 throwaway26425 changed the title [FR] Make "Oscar" the default theme. Simple theme: layout issues Mar 5, 2022
@ACodingGenie
Copy link

Lit bit of a different request here. Would it be possible to provide a toggle in the settings or settings.yml to permanently hide the suggestions and search URL boxes? I use a private instance and have never had the need to use either one and not to mention the result's page does look cleaner. My use case is a bit limited so IDK!

dalf added a commit to dalf/searxng that referenced this issue Mar 8, 2022
return42 pushed a commit to return42/searxng that referenced this issue Mar 19, 2022
@mrpaulblack
Copy link
Member

Yes you are right about the simple theme moving the suggestions to the middle of the screen on landscape mode on mobile devices; The reason is that we only use screenwidths with CSS for the different layouts...

Here you can the screen size definitions:

/// General Size
@results-width: 45rem;
@results-offset: 10rem;
@results-tablet-offset: 0.5rem;
@results-gap: 5rem;
@results-margin: 0.125rem;
@result-padding: 1rem;
@results-image-row-height: 12rem;
@results-image-row-height-phone: 6rem;
@search-width: 40rem;
// heigh of #search, see detail.less
@search-height: 7.6rem;
/// Device Size
/// @desktop > @tablet
@tablet: 79.75em; // see https://github.com/searxng/searxng/issues/874
@phone: 50em;
@small-phone: 35em;
@ultra-small-phone: 20rem;

Basically on desktop the suggestions and everything are on the right and all other platforms (tablet and phone) the suggestions are in the middle.

As you can see the results on simple theme are much wider than oscar and therefor the suggestions (and infobar) are not moved to the right. This is a design decision to make the simple theme well simpler and I believe that is not that big of a deal you can just scroll down a bit on mobile and the results themselves show more content then oscar since they are wider...

If we would really want to patch this we could make the results on tablet (since landscape phone is already falling into tablet width) smaller and move the suggestions to the right and the results to the left, but I am like them centered more and are kinda meh about that change tbh.

@return42
Copy link
Member

If we would really want to patch this we could make the results on tablet (since landscape phone is already falling into tablet width) smaller and move the suggestions to the right and the results to the left, but I am like them centered more and are kinda meh about that change tbh.

I agree with with @mrpaulblack / it is better to have a full with result list on devices other than desktop. Especial embedded videos should be shown in full with:

grafik

@return42
Copy link
Member

that's half of the screen...

for me it is OK to scroll as long I have full width result list .. did you ever tried google? .. they have only 3 results at the end of the page.

@throwaway26425 throwaway26425 changed the title Simple theme: layout issues . Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: simple theme bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants