(feat) add jisho.org

[austinhuang0131]

What does this PR do?

Add https://jisho.org as an engine. Note that this only supports searching words (either English or Japanese input).

A longer infobox:

Why is this change important?

¯\_(ツ)_/¯

How to test this PR locally?

make run test

Author's checklist

Related issues

Closes #1016

[dalf]

Some comments here and there

[dalf]

Does it always close an <i> ?
What about infobox_content += f" ({extra})" and infobox_content += '</ul><small>Wikipedia, CC BY-SA 3.0.</small><ul>' ?

[austinhuang0131]

You mean <li>

What about infobox_content += f" ({extra})"

There always exist engdef. Plus <li> is always appended since I have both an if and an else

and infobox_content += '</ul><small>Wikipedia, CC BY-SA 3.0.</small><ul>'

At the very top I exclude any entries whose first entry is Wikipedia. My understanding is that the dictionary entries are always before Wikipedia entries.

[dalf]

This is the topic of another issue and PR : the infobox template is missing a field about the license:
https://github.com/searxng/searxng/blob/master/searx/templates/simple/infobox.html

[austinhuang0131]

This should be documented imo

[return42]

Sorry I haven't had time to test in deep yet, but a first try results in a IndexError:

Traceback (most recent call last):
  File "SearXNG/searx/search/processors/online.py", line 143, in search
    search_results = self._search_basic(query, params)
  File "SearXNG/searx/search/processors/online.py", line 131, in _search_basic
    return self.engine.response(response)
  File "SearXNG/searx/engines/jisho.py", line 43, in response
    if page['senses'][0]['parts_of_speech'][0] != 'Wikipedia definition':
IndexError: list index out of range

---

Should it be

engine_type = 'online_dictionary'

[dalf]

Should it be engine_type = 'online_dictionary'

yes and no.

• yes, because it would be nice to en-ja house to pick the right engine.
• no, because both !jisho house or !jisho 家 and there is no syntax to say "auto detect" to "English" for example (no user query syntax and no implementation).
• no because wordnik and other dictionnaries don't use the online_dictionnary.
  --> there is a global task about the dictionaries.

@austinhuang0131 > I have refactored the code in dalf@0e2754e . Can you have a look?

[austinhuang0131]

That's good, you can use it as-is.

[dalf]

Merged. Thank you!

[Nocifer]

Wow, that's what I'd call a very prompt response. Thank you all for the effort!