-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
settings.yml: remove locales section. #247
Conversation
make sure Firefox in test.robot asks for English pages
There are detected from the searx/translations directory
527a224
to
f30d01f
Compare
ping @MarcAbonce |
searx/locales.py
Outdated
RTL_LOCALES: Set[str] = set() | ||
"""List of *Right-To-Left* locales e.g. 'he' or 'fa_IR' (delimiter is | ||
*minus* '-')""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delimiter is *minus* '-'
--> delimiter is *minus* '_'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops .. fixed.
For most of the exceptions I would advocate for sticking with Babel's (actually Unicode CLDR's) names:
On the other hand, I think that using Vlaams over Nederlands for Edit: But it's worth mentioning that I don't know anything about these languages other than by skimming their Wikipedia articles. But precisely because of that I would prefer to trust the Unicode CLDR over our own personal intuitions, at least in most cases. |
- Add ``# lint: pylint`` header to pylint this python file. - Fix issues reported by pylint. - Add source code documentation of modul searx.locales Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
4bee131
to
809bf1a
Compare
Updated. Thank you ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM .. lets merge.
What does this PR do?
In settings.yml, remove the
locales
section.The available locales are detected from the
searx/translations
directory.Babel provides the locale names and write direction (rtl, ltr).
There are some exceptions:
The locale names: the names are changed for the rows that start with
!
:code to generate this table
Why is this change important?
Related to #195 and #228 :
settings.yml
might not be synchronized with the git repository.settings.yml
(from weblate).How to test this PR locally?
make test
Author's checklist
Related issues