[feat] new engine: wikispecies #2589
Conversation
searx/engines/mediawiki.py
Outdated
| @@ -86,7 +86,7 @@ def response(resp): | |||
| ) | |||
|
|
|||
| # append result | |||
| results.append({'url': url, 'title': result['title'], 'content': ''}) | |||
| results.append({'url': url, 'title': result['title'], 'content': result.get('snippet', '')}) | |||
There was a problem hiding this comment.
Wow this is rocket cool, it (BTW) fixes the content field of wikibooks, wikinews, wikiquote .. and all the other mediawiki engines 👍
In my review I will strip the HTML tags from the snippet .. coming soon.
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
The Wikimedia wikis [1] engines provide good answers and have short response times --> no reason to disable these enhgines by default. BTW: this patch adds a (sub-) category ``wikimedia`` for the engines [1]. [1] https://meta.wikimedia.org/wiki/Wikimedia_wikis Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
|
@Bnyro I added two commits on top of your branch .. can you please have a look / thanks 👍
@Bnyro, @unixfox what do you think about the 2nd patch ... is it OK or does it pollute the result list a bit too much? |
|
That looks awesome in my opinion. |
After using this setting for a while I'm no longer sure if it was a good decision to activate theses engines by default (a96b6f3) / in the general category I often get to many results with a ranking on top of the result list. By example: when I query for markdown I got to many results I didn't was looking for. Should we better deactivate these engines by default? Or should we rank ( |
|
I think it's better to weight them lower, since they do in fact provide good results. |
The search engines deliver hits for many search terms [1], but these are usually not the focus of the user. In order to arrange these hits further down in the list, their weighting is reduced. [1] searxng#2589 (comment) Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
… wikiversity The search engines deliver hits for many search terms [1], but these are usually not the focus of the user. In order to arrange these hits further down in the list, their weighting is reduced. [1] searxng#2589 (comment) Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
I would prefer to deactivate them, I never really got any meaningful results from them. In fact, I have disabled them on searx.be I think we should be very careful with what engines we add as enabled by default for the General category, some people will not like if we add too many new kind of engines (4 new engines enabled by default in a row is a lot). |
… wikiversity The search engines deliver hits for many search terms [1], but these are usually not the focus of the user. In order to arrange these hits further down in the list, their weighting is reduced. [1] searxng#2589 (comment) Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
… wikiversity The search engines deliver hits for many search terms [1], but these are usually not the focus of the user. In order to arrange these hits further down in the list, their weighting is reduced. [1] searxng#2589 (comment) Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
… wikiversity The search engines deliver hits for many search terms [1], but these are usually not the focus of the user. In order to arrange these hits further down in the list, their weighting is reduced. [1] #2589 (comment) Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
What does this PR do?
Why is this change important?
How to test this PR locally?
Related issues
closes #1222