-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] engine: support for Odysee #2656
Conversation
For reference here: #590 |
And please use the |
Hi @Hackurei thanks a lot for your PR .. before we go into a review, the patches should pass the quality gate from CI .. as you can see in "Some checks were not successful" there are some fixes needed to pass the quality gate .. I recommend to study at least our Development Quickstart .. further it would be good to squash your 5 commits into one commit [ref] with a meaningful commit messages. |
hello, please understand i do not have time to work on this right now, i will come back in a few weeks / months. |
The changes seem pretty decent so far, would you mind if anyone else continues working on your PR and finalizing it? |
@Bnyro you can if you want. i still need to learn how to squash everything into 1 commit though. also embedded videos are looking good with the videos.html now, yay! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i still need to learn how to squash everything into 1 commit though.
No problem .. I squashed the commits rebased your branch on SXNG's master and did some modifications (see my comments from the review).
also embedded videos are looking good with the videos.html now, yay!
Works like a charme :) .. well done 👍 .. thanks a lot for your work to add odysee to SXNG / I think Odysee is a very valuable addition to the videos category ... maybe we can get more out of it ... I'd still like to find the API for it.
[1] #2656 (review) Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
What does this PR do?
Adds the Odysee engine!
Why is this change important?
People will like it, it was actually requested over on the searx github: searx/searx#2504
How to test this PR locally?
make a search like- test !od
Author's checklist
the reason i also made odysee_videos.html is because the embedded videos did not look quite right when using videos.html