Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] engine: support for Odysee #2656

Merged
merged 1 commit into from
Sep 2, 2023
Merged

[feat] engine: support for Odysee #2656

merged 1 commit into from
Sep 2, 2023

Conversation

Austin-Olacsi
Copy link
Contributor

What does this PR do?

Adds the Odysee engine!

Why is this change important?

People will like it, it was actually requested over on the searx github: searx/searx#2504

How to test this PR locally?

make a search like- test !od

Author's checklist

the reason i also made odysee_videos.html is because the embedded videos did not look quite right when using videos.html

@Bnyro
Copy link
Member

Bnyro commented Aug 18, 2023

For reference here: #590

@Bnyro
Copy link
Member

Bnyro commented Aug 18, 2023

And please use the videos.html template (if someone else confirms that), I don't think it's worth adding a new template solely for odysee here.

@return42
Copy link
Member

return42 commented Aug 18, 2023

Hi @Hackurei thanks a lot for your PR .. before we go into a review, the patches should pass the quality gate from CI .. as you can see in "Some checks were not successful" there are some fixes needed to pass the quality gate .. I recommend to study at least our Development Quickstart .. further it would be good to squash your 5 commits into one commit [ref] with a meaningful commit messages.

@Austin-Olacsi Austin-Olacsi marked this pull request as draft August 18, 2023 22:06
@Austin-Olacsi
Copy link
Contributor Author

hello, please understand i do not have time to work on this right now, i will come back in a few weeks / months.

@Bnyro
Copy link
Member

Bnyro commented Sep 1, 2023

The changes seem pretty decent so far, would you mind if anyone else continues working on your PR and finalizing it?

@Austin-Olacsi
Copy link
Contributor Author

@Bnyro you can if you want. i still need to learn how to squash everything into 1 commit though. also embedded videos are looking good with the videos.html now, yay!

@return42 return42 marked this pull request as ready for review September 2, 2023 06:44
Copy link
Member

@return42 return42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i still need to learn how to squash everything into 1 commit though.

No problem .. I squashed the commits rebased your branch on SXNG's master and did some modifications (see my comments from the review).

also embedded videos are looking good with the videos.html now, yay!

Works like a charme :) .. well done 👍 .. thanks a lot for your work to add odysee to SXNG / I think Odysee is a very valuable addition to the videos category ... maybe we can get more out of it ... I'd still like to find the API for it.

docs/dev/engines/online/odysee.rst Show resolved Hide resolved
searx/engines/odysee.py Show resolved Hide resolved
searx/engines/odysee.py Show resolved Hide resolved
searx/engines/odysee.py Show resolved Hide resolved
@return42 return42 merged commit 4da7003 into searxng:master Sep 2, 2023
8 checks passed
return42 added a commit that referenced this pull request Sep 2, 2023
[1] #2656 (review)

Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants