[fix] keyboard navigation / simple theme (UI) Fix 2751 & 2788

[BernieHuang2008]

What does this PR do?

fixed both #2751 and #2788 at the same time .

By finding the next result manually insdead of using .nextElementSibling.

Why is this change important?

fixed bugs and improve UX

How to test this PR locally?

search the keyword below and try to navigate between groups.

Author's checklist

Related issues

Closes #2751
Closes #2788

[return42]

Wow, very cool .. I squashed your third commit into you first commit and modified the commit message .. hope thats OK for you ..

One point I have, I think the previous-/next-ElementSibling is superfluous here and the if-condition can be remove .. what to you think about this patch of your code? -->

diff --git a/searx/static/themes/simple/src/js/main/keyboard.js b/searx/static/themes/simple/src/js/main/keyboard.js
index ae324aadd..5c02acbfd 100644
--- a/searx/static/themes/simple/src/js/main/keyboard.js
+++ b/searx/static/themes/simple/src/js/main/keyboard.js
@@ -234,16 +234,10 @@ searxng.ready(function () {
           }
           break;
         case 'down':
-          next = current.nextElementSibling;
-          if (next === null) {
-            next = results[results.indexOf(current) + 1];
-          }
+          next = results[results.indexOf(current) + 1] || current;
           break;
         case 'up':
-          next = current.previousElementSibling;
-          if (next === null) {
-            next = results[results.indexOf(current) - 1];
-          }
+          next = results[results.indexOf(current) - 1] || current;
           break;
         case 'bottom':
           next = results[results.length - 1];

[BernieHuang2008]

can't agree with you more ~

[return42]

can't agree with you more ~

:) .. I squashed my patch from above into your commit (see diff) and rebuild the static files ..

Before we merge .. can you please check if my modification do work as expected (in all edge cases) / thanks!

[BernieHuang2008]

tested, everything right.

[return42]

tested, everything right.

OK / thanks! .. I'm going to merge .. I want to have this merged, before we going to start the preferences --> #2788 (comment)