[mod] preferences: implement drop-down menu for hotkeys (default, vim) #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BernieHuang2008
suggested changes
Sep 16, 2023
Bnyro
reviewed
Sep 17, 2023
Bnyro
reviewed
Sep 17, 2023
Bnyro
approved these changes
Sep 17, 2023
return42
force-pushed
the
pref-hotkeys
branch
from
ec19d4f
to
5c68aee
Compare
BernieHuang2008
approved these changes
Sep 17, 2023
|
You'll need further reviews and testings. |
Bnyro
reviewed
Sep 17, 2023
Bnyro
reviewed
Sep 17, 2023
|
I think mistakes like description/spelling is not so important now, because we will clean the code after this PR merged. |
return42
force-pushed
the
pref-hotkeys
branch
from
5c68aee
to
f1d9b96
Compare
Sure, but since we're already working on the files that contain the descriptions we can also just make this PR "perfect" and save time that would be needed for creating and reviewing new PRs. |
return42
force-pushed
the
pref-hotkeys
branch
from
f1d9b96
to
ccd2223
Compare
Replace the on/off checkbox of the vim-hotkeys in the preferences by a drop-down menu. Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42
force-pushed
the
pref-hotkeys
branch
from
ccd2223
to
af51172
Compare
|
Rebased to solve conflict with preferences and build files .. going to merge to avoid further conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replace the on/off checkbox of the vim-hotkeys in the preferences by a drop-down menu.
How to test this PR locally?
Start instance
make run, go to the preferences and select a "hotkeys" layout, save the settings, do a query and press 'h' in the result list.@BernieHuang2008 I cherry picked your commit in this PR and slightly modified the commit to fix an issue .. and I rewrote the commit message / thanks a lot for your patch 馃憤