Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] drop useless pylint: disable=undefined-variable #300

Merged
merged 2 commits into from Sep 7, 2021

Conversation

return42
Copy link
Member

@return42 return42 commented Sep 7, 2021

What does this PR do?

Since 7b235a1 (see line 591) it is no longer needed to disable undefined-variable for names defined in::

PYLINT_ADDITIONAL_BUILTINS_FOR_ENGINES

Suggested-by: @dalf #102 (comment)

How to test this PR locally?

make test.pylint

Related issues

Closes: #102

Since 7b235a1 (see line 591) it is no longer needed to disable
'undefined-variable' for names defined in::

   PYLINT_ADDITIONAL_BUILTINS_FOR_ENGINES

Suggested-by: @dalf searxng#102 (comment)
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
androp no longer needed (see line 591 in 7b235a1)::

    # pylint: disable=undefined-variable

Suggested-by: @dalf searxng#102 (comment)
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
@return42 return42 requested a review from dalf September 7, 2021 08:38
@dalf dalf merged commit 9ef7f38 into searxng:master Sep 7, 2021
@return42 return42 deleted the fix-engine-pylint branch September 7, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About pylint configuration
2 participants