Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[simple theme] remove '-moz-border-radius' property #537

Merged
merged 3 commits into from
Nov 23, 2021

Conversation

return42
Copy link
Member

@return42 return42 commented Nov 23, 2021

What does this PR do?

[simple theme] remove '-moz-border-radius' & '-webkit-border-radius' property

Support for the prefixed version (-moz-border-radius) was removed in Gecko
13.0 (Firefox 13.0 / Thunderbird 13.0 / SeaMonkey 2.10) [1].

[1] https://developer.mozilla.org/pt-BR/docs/Web/CSS/border-radius

Why is this change important?

Remove warning spam from the console ..

grafik

How to test this PR locally?

Open SearXNG site in FFox browsers

Copy link
Member

@mrpaulblack mrpaulblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
IMO I dont think we need to leave this in for such old browser version tbh; so agreed with the PR

@dalf
Copy link
Member

dalf commented Nov 23, 2021

What about -webkit-border-radius ? Do we remove it ?

@mrpaulblack
Copy link
Member

Safari ignores border-radius on <select> elements unless -webkit-appearance is overridden to an appropriate value.

So I would keep the webkit vendor prefix since there is a 5px border radius on the select elements...

@dalf
Copy link
Member

dalf commented Nov 23, 2021

Okay, let's keep the webkit vendor prefix ( https://caniuse.com/?search=css3%20border-radius doesn't make a reference to this. )


Using CSS grids, the simple theme requires Safari 10.1 on OSX and Safari 10.3 on iOS: https://caniuse.com/?search=grid

@return42
Copy link
Member Author

Hm, I am a little bit confused ..

Safari ignores border-radius on <select> elements unless -webkit-appearance is overridden to an appropriate value.

... who says?

Okay, let's keep the webkit vendor prefix ( https://caniuse.com/?search=css3%20border-radius doesn't make a reference to this. )

.. when I look at https://caniuse.com/?search=css3%20border-radius I can see border-radius is supported since 2010 (macOS & iOS)

.. or I am wrong? / If not I would like to remove -webkit-border-radius like @dalf suggested in the first place.

return42 added a commit to return42/searxng that referenced this pull request Nov 23, 2021
[1] searxng#537 (comment)

Suggested-by: @dalf [1]
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
@return42
Copy link
Member Author

FWIW: I removed -webkit-border-radius as @dalf suggested .. maybe there is someone who can test this PR in Safari ...

@mrpaulblack
Copy link
Member

mrpaulblack commented Nov 23, 2021

... who says?

Check the notes on safari in the compat. table: https://developer.mozilla.org/pt-BR/docs/Web/CSS/border-radius

The tradeoff if we remove it would be that the border radius in pref on the select boxes wont work on safari; but cannot test this and dont know if its worth keeping it just for that tbh...

@dalf
Copy link
Member

dalf commented Nov 23, 2021

  • The MDN documentation is not clear:
    • it seems it's about the Chrome version 1 to 4
    • the English version doesn't have this information
  • <select style="border-radius: 1rem">... works on Chrome : https://jsfiddle.net/dalf73/nk6x9y1a/1/

@return42
Copy link
Member Author

Check the notes on safari in the compat.

Ooops . I have overlooked this / thanks.

it seems it's about the Chrome version 1 to 4

Chrome? .. @mrpaulblack mentioned Safari

MDN is talking about Safari 5.0

grafik

Safari 6.0 is on the market since 2012, I think we can drop the vendor prefix in this case.

Support for the prefixed version (-moz-border-radius) was removed in Gecko
13.0 (Firefox 13.0 / Thunderbird 13.0 / SeaMonkey 2.10) [1].

[1] https://developer.mozilla.org/pt-BR/docs/Web/CSS/border-radius

Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
[1] searxng#537 (comment)

Suggested-by: @dalf [1]
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
@return42 return42 merged commit dae165e into searxng:master Nov 23, 2021
@return42 return42 deleted the moz-warnings branch November 23, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants