-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[simple theme] remove '-moz-border-radius' property #537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
IMO I dont think we need to leave this in for such old browser version tbh; so agreed with the PR
What about |
So I would keep the webkit vendor prefix since there is a 5px border radius on the select elements... |
Okay, let's keep the webkit vendor prefix ( https://caniuse.com/?search=css3%20border-radius doesn't make a reference to this. ) Using CSS grids, the simple theme requires Safari 10.1 on OSX and Safari 10.3 on iOS: https://caniuse.com/?search=grid |
Hm, I am a little bit confused ..
... who says?
.. when I look at https://caniuse.com/?search=css3%20border-radius I can see .. or I am wrong? / If not I would like to remove |
[1] searxng#537 (comment) Suggested-by: @dalf [1] Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
5da08c8
to
387e8ef
Compare
FWIW: I removed |
Check the notes on safari in the compat. table: https://developer.mozilla.org/pt-BR/docs/Web/CSS/border-radius The tradeoff if we remove it would be that the border radius in pref on the select boxes wont work on safari; but cannot test this and dont know if its worth keeping it just for that tbh... |
|
Ooops . I have overlooked this / thanks.
Chrome? .. @mrpaulblack mentioned Safari MDN is talking about Safari 5.0 Safari 6.0 is on the market since 2012, I think we can drop the vendor prefix in this case. |
Support for the prefixed version (-moz-border-radius) was removed in Gecko 13.0 (Firefox 13.0 / Thunderbird 13.0 / SeaMonkey 2.10) [1]. [1] https://developer.mozilla.org/pt-BR/docs/Web/CSS/border-radius Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
[1] searxng#537 (comment) Suggested-by: @dalf [1] Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
387e8ef
to
3364a15
Compare
What does this PR do?
[simple theme] remove '-moz-border-radius' & '-webkit-border-radius' property
Support for the prefixed version (-moz-border-radius) was removed in Gecko
13.0 (Firefox 13.0 / Thunderbird 13.0 / SeaMonkey 2.10) [1].
[1] https://developer.mozilla.org/pt-BR/docs/Web/CSS/border-radius
Why is this change important?
Remove warning spam from the console ..
How to test this PR locally?
Open SearXNG site in FFox browsers