New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove no longer maintained scripts from searxng_extra #651
Conversation
IMO we should keep
|
Script did not work / is not maintained. Closes: searxng#332 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Script did not work / is not maintained. Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
4d188c5
to
c944670
Compare
Yes I also like to have a command line .. but one that works :-) .. try:
For me it is not clear what use case of this implementation is / is the command line started like shown above? .. or do I need to install ( We can implement a command line but then it should be placed in a folder ./cli (or similar). At the of the reorganization of SearXNG I see the following root folders in the repository:
If you want, we can implement a command line, but this broken code in standalone_searx.py want help us I think. |
A quick fix diff --git a/searxng_extra/standalone_searx.py b/searxng_extra/standalone_searx.py
index e243d9cb..de8a0d77 100755
--- a/searxng_extra/standalone_searx.py
+++ b/searxng_extra/standalone_searx.py
@@ -196,9 +196,14 @@ def parse_argument(
if __name__ == '__main__':
- searx.search.initialize()
+ settings_engines = searx.settings['engines']
+ searx.search.load_engines(settings_engines)
engine_cs = list(searx.engines.categories.keys())
prog_args = parse_argument(category_choices=engine_cs)
+ searx.search.initialize_network(settings_engines, searx.settings['outgoing'])
+ searx.search.check_network_configuration()
+ searx.search.initialize_metrics([engine['name'] for engine in settings_engines])
+ searx.search.initialize_processors(settings_engines)
search_q = get_search_query(prog_args, engine_categories=engine_cs)
res_dict = to_dict(search_q)
sys.stdout.write(dumps( What happens with The fix is to load the engines but to initialize them only after the arguments parsing. The engines must be loaded first to be able to display the category list in the help message.
I don't understand what goes into this folder.
An alternative is to move |
@dalf thanks .. but:
I would vote to implement a generic command line which can be started by Its up to your decision, if want, we can keep
Somewhere in the future, the source of the HTML-CSS-JS clients could be moved into this folder, e.g.:
|
What are they?
I would like to keep it, so we can take time to implement a new script. If someone wants a command line the existing script still provides some values. |
The |
Replaced by #658 |
Stuff in folder searxng_extra/ is not suitable for normal users and should only be used by developers. The script searxng_extra/standalone_searx.py must not give the impression that it improves privacy. [1] [1] searxng#651 (comment) Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Stuff in folder searxng_extra/ is not suitable for normal users and should only be used by developers. The script searxng_extra/standalone_searx.py must not give the impression that it improves privacy. [1] [1] searxng#651 (comment) Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
What does this PR do?
remove no longer maintained scripts from searxng_extra
Why is this change important?
tidy up
Related issues