[mod] manage: add themes.live command (rebuild on modification) #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I left a comment regarding the error message. Otherwise LGTM :) |
To have a live build while editing the HTML client of a theme. The first
argument of the command is the theme name:
./manage themes.live simple
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Environment variable to get live builds while modifying CSS & JS of a theme::
LIVE_THEME=simple make run
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42
force-pushed
the
themes.live
branch
from
57f9350
to
c7f2740
Compare
not-my-profile
approved these changes
Jan 4, 2022
return42
added a commit
to return42/searxng
that referenced
this pull request
Jan 5, 2022
Commit c7f2740 moves the 'python -m searx.webapp' process to the background. A background job can't open a simple python-debugger (pdb) console. This patch moves all processes to the background except the searx.webapp. Insert a debug point somewhere in the webapp application:: import pdb pdb.set_trace() And start a debug session by and test you break point:: make run To test that the entire 'make run' stops in the case of an error in the themes.live background process try: make LIVE_THEME=typo-theme-name run [1] searxng#664 (comment) Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42
added a commit
to return42/searxng
that referenced
this pull request
Jan 5, 2022
Commit c7f2740 moves the `python -m searx.webapp` process to the background. A background job can't open a simple python-debugger (pdb) console. This patch moves all processes to the background except the searx.webapp. Insert a break point somewhere in the webapp application:: import pdb pdb.set_trace() And start a debug session by:: make run and test you break point. To test that the entire 'make run' stops in the case of an error in the themes.live [1] background process try: make LIVE_THEME=typo-theme-name run [1] searxng#664 (comment) Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[mod] manage: add themes.live command (rebuild on modification)
Why is this change important?
To get live builds while editing the HTML client of a theme. The first argument of the command is the theme name:
To get live builds on
make runuse environment variable:How to test this PR locally?
Start developer session:
and edit CSS (LESS) & JS of the simple theme.
Related issues