Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] bandcamp: fix itemtype (album|track) and exceptions #900

Merged
merged 2 commits into from
Feb 19, 2022

Conversation

return42
Copy link
Member

@return42 return42 commented Feb 17, 2022

[fix] bandcamp: fix itemtype (album|track) and exceptions

BTW: make polish implementation and show tracklist

Closes: #883


Track Player:

grafik

Album with track list:

grafik

BTW: polish implementation and show tracklist for albums

Closes: searxng#883
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
@dalf
Copy link
Member

dalf commented Feb 19, 2022

Works flawlessly.

  • new_result['thumbnail'] = thumbnail[0] gives big thumbnail.
  • new_result['img_src'] = thumbnail[0] seems better:

image

but then the genius engine needs to be updated too.

@dalf dalf merged commit ace5401 into searxng:master Feb 19, 2022
@return42 return42 deleted the fix-883 branch February 19, 2022 13:59
return42 added a commit to return42/searxng that referenced this pull request Feb 19, 2022
Suggested-by: @dalf searxng#900 (comment)
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42 added a commit to return42/searxng that referenced this pull request Feb 21, 2022
Suggested-by: @dalf searxng#900 (comment)
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bandcamp engine needs some polish
2 participants