add previousCondition to JRuleWhenItemChange #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I've not tested it, waiting for #85 to be finalized first. |
seime
reviewed
Dec 24, 2022
.../binding/jrule/internal/rules/triggers/itemchangecondition/JRuleItemChangeConditionTest.java
Outdated
Show resolved
Hide resolved
...binding/jrule/internal/rules/triggers/itemchangecondition/JRuleItemChangeConditionRules.java
Outdated
Show resolved
Hide resolved
seime
approved these changes
Dec 26, 2022
|
Appears to run fine in my env, at least no visible negative impact. Merging |
querdenker2k
added a commit
to querdenker2k/jrule
that referenced
this pull request
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added previousCondition to JRuleWhenItemChange.
Triggers the rule just in case the previous state was of a specific state.
My current UseCase: Twilight is higher then 50lux and the twilight was before less then 50lux.