Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Item constants constant #128

Merged
merged 6 commits into from
Feb 20, 2023
Merged

Make Item constants constant #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dec16ed
Fixed contact item issue #113
seaside1 Dec 30, 2022
18a1509
fix the other item constants
querdenker2k Feb 13, 2023
5cc3f24
Merge remote-tracking branch 'origin/main' into contactitem_fix
querdenker2k Feb 13, 2023
05da852
Merge remote-tracking branch 'origin/main' into contactitem_fix
querdenker2k Feb 17, 2023
73149e6
stabilize IT timer test
querdenker2k Feb 17, 2023
522e560
revert
querdenker2k Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/openhab/automation/jrule/items/JRuleDimmerItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
* @author Robert Delbrück - Initial contribution
*/
public interface JRuleDimmerItem extends JRuleSwitchItem {
String INCREASE = JRuleIncreaseDecreaseValue.INCREASE.stringValue();
String DECREASE = JRuleIncreaseDecreaseValue.DECREASE.stringValue();
String INCREASE = "INCREASE";
String DECREASE = "DECREASE";

static JRuleDimmerItem forName(String itemName) throws JRuleItemNotFoundException {
return JRuleItemRegistry.get(itemName, JRuleInternalDimmerItem.class);
Expand Down
12 changes: 6 additions & 6 deletions src/main/java/org/openhab/automation/jrule/items/JRulePlayerItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@
* @author Robert Delbrück - Initial contribution
*/
public interface JRulePlayerItem extends JRuleItem {
String PLAY = JRulePlayPauseValue.PLAY.stringValue();
String PAUSE = JRulePlayPauseValue.PAUSE.stringValue();
String NEXT = JRuleNextPreviousValue.NEXT.stringValue();
String PREVIOUS = JRuleNextPreviousValue.PREVIOUS.stringValue();
String REWIND = JRuleRewindFastforwardValue.REWIND.stringValue();
String FASTFORWARD = JRuleRewindFastforwardValue.FASTFORWARD.stringValue();
String PLAY = "PLAY";
String PAUSE = "PAUSE";
String NEXT = "NEXT";
String PREVIOUS = "PREVIOUS";
String REWIND = "REWIND";
String FASTFORWARD = "FASTFORWARD";

static JRulePlayerItem forName(String itemName) throws JRuleItemNotFoundException {
return JRuleItemRegistry.get(itemName, JRuleInternalPlayerItem.class);
Expand Down
8 changes: 4 additions & 4 deletions src/main/java/org/openhab/automation/jrule/items/JRuleRollershutterItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@
* @author Robert Delbrück - Initial contribution
*/
public interface JRuleRollershutterItem extends JRuleItem {
String STOP = JRuleStopMoveValue.STOP.stringValue();
String MOVE = JRuleStopMoveValue.MOVE.stringValue();
String UP = JRuleUpDownValue.UP.stringValue();
String DOWN = JRuleUpDownValue.DOWN.stringValue();
String STOP = "STOP";
String MOVE = "MOVE";
String UP = "UP";
String DOWN = "DOWN";

static JRuleRollershutterItem forName(String itemName) throws JRuleItemNotFoundException {
return JRuleItemRegistry.get(itemName, JRuleInternalRollershutterItem.class);
Expand Down