Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed group item class generation #138

Merged
merged 6 commits into from
Mar 8, 2023
Merged

Conversation

gerrieg
Copy link
Contributor

@gerrieg gerrieg commented Mar 4, 2023

For a group of Number:Temperature items, the group is generated incorrectly and the JRuleItems class cannot be compiled.

.items file:

Group gTemperature

Number:Temperature Item_1 (gTemperature)
Number:Temperature Item_2 (gTemperature)

generated JRuleItems class:

public static JRuleNumber:TemperatureGroupItem gTemperature;

gTemperature = JRuleItemRegistry.get("gTemperature", JRuleInternalNumber:TemperatureGroupItem.class);

This patch fixed it for me

Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
@seime seime requested a review from querdenker2k March 6, 2023 10:18
@querdenker2k
Copy link
Collaborator

@gerrieg Could you please add a test for this, to be sure that the error not occurs again

@gerrieg
Copy link
Contributor Author

gerrieg commented Mar 6, 2023

I quickly looked at the test classes and I can't see where the test should be added. Do you have a hint or are you kind enough to add the test yourself? Unfortunately, I don't have the time to take a close look at everything.
Thank you!

@querdenker2k querdenker2k merged commit 0eb3ba6 into seaside1:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants