Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OpenClosedItem #4

Merged
merged 1 commit into from Oct 25, 2021

Conversation

Dbzman
Copy link
Contributor

@Dbzman Dbzman commented Oct 23, 2021

I took the chance to replace the copyright year as well.

Copy link
Owner

@seaside1 seaside1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had some problems setting up my dev environment, but finally got it working.
I was considering naming The OpenClosedItem to ContactItem, but since it is named OpenClosed item in openhab-core it is probably best to have this name.

Only comment I have is that your IDEA transformed some of the imports to import *, i'll fix that in my next commit. Good work, and thank you for the contribution.

@seaside1 seaside1 merged commit 99989d8 into seaside1:main Oct 25, 2021
@Dbzman
Copy link
Contributor Author

Dbzman commented Oct 26, 2021

Yeah, I had similar thoughts on the naming and I think you're right. It's good to stick to the openhab-core. On the other side, I just took a look at the documentation again.
https://www.openhab.org/docs/configuration/items.html#type
I guess you named every item class after the "Type Name" column so far. Given that it may be better to use ContactItem.

I'll take a look at my IDE settings for the next time. Thanks for merging. :)

seaside1 added a commit that referenced this pull request Apr 5, 2022
Add support for OpenClosedItem

Former-commit-id: 99989d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants