Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event for channel #52

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Conversation

querdenker2k
Copy link
Collaborator

currently there is no event option for channel triggers. but for e.g. astro binding there is START and END.
Furthermore i did some refactoring/cleanup

@seime
Copy link
Collaborator

seime commented Oct 9, 2022

Good!

Also fully agree on the refactoring. I'm about to throw in Thing support as well, and I've been thinking the same.

We also should do something about the JRuleEvent class (splitting, and making references to items & things typed and not String fields)

@seaside1 what do you think?

@seaside1
Copy link
Owner

seaside1 commented Oct 9, 2022

Make sense to me. Will try it out a bit before merge.

@querdenker2k
Copy link
Collaborator Author

Is there any binding where i can generate (throw) events very often or maybe with item triggering for testing? I am just using Astro, but waiting one day to test channel/event triggering is not funny.

@seime
Copy link
Collaborator

seime commented Oct 13, 2022

@querdenker2k Could not find any doc's saying openhab console would do the trick for triggers.

There is some code here, but you need to extend it in order to create ChannelTriggerEvents; https://github.com/seaside1/jrule-user

Beside that, I'm working on better testing support, but it isn't ready to share just yet (part of my rules repo)

@querdenker2k
Copy link
Collaborator Author

but, this will not be enough to test the JRule implementation.
You know any binding which fires a log of channel triggers?
I need something to be sure that my changes are working, especialy for the JRuleWhenXXX refactoring.

@seaside1
Copy link
Owner

Did some basic testing, seems to be ok, so merging

@seaside1 seaside1 merged commit 3ed80ee into seaside1:main Oct 14, 2022
@seime seime mentioned this pull request Oct 16, 2022
@querdenker2k querdenker2k deleted the add_event_for_channel branch October 26, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants