Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAGettextExporter catalog generation issues #1369

Closed
jbrichau opened this issue Jul 17, 2023 · 0 comments
Closed

WAGettextExporter catalog generation issues #1369

jbrichau opened this issue Jul 17, 2023 · 0 comments

Comments

@jbrichau
Copy link
Member

jbrichau commented Jul 17, 2023

Couple of issues to be fixed, which either already existed or are newly introduced in the new implementation included in Seaside 3.4.x:

  • The comment of each translation entry in the .pot (catalog) file exported by WAGettextExporter may contain a method multiple times if multiple translation strings are in the method (this was already the case). A method should be included only once.
  • The package name included in each comment is the package name of the class, not that of the method. Moreover, since multiple methods can be listed, the package name of the only first method is shown. We can safely remove the package name from the comment since the class name is sufficient to identify the method location.
  • The meta header was removed from the .pot (catalog) file in the reimplementation.
  • There is no interface to restrict the extraction of strings to a subset of packages.
jbrichau added a commit that referenced this issue Jul 17, 2023
jbrichau added a commit that referenced this issue Jul 17, 2023
…g-generation-issues

Fix for issue #1369 (improvements for WAGettextExporter)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant