fix rollback error log #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luky116
approved these changes
Jan 20, 2023
106umao
approved these changes
Feb 1, 2023
| @@ -174,7 +174,9 @@ func (c *ATConn) createNewTxOnExecIfNeed(ctx context.Context, f func() (types.Ex | |||
| log.Errorf("conn at rollback error:%v or recoverErr:%v", err, recoverErr) | |||
| if tx != nil { | |||
| rollbackErr := tx.Rollback() | |||
| log.Errorf("conn at rollback error:%v", rollbackErr) | |||
| if rollbackErr != nil { | |||
There was a problem hiding this comment.
建议写成这种形式
if rollbackErr := tx.Rollback();rollbackErr != nil {
log.Errorf("conn at rollback error:%v", rollbackErr)
}
georgehao
pushed a commit
to georgehao/seata-go
that referenced
this pull request
May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
加上判断
Which issue(s) this PR fixes:
error日志重复打印
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: