Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear the transaction context in TCC prepare methed #1195

Merged
merged 5 commits into from Jun 13, 2019

Conversation

zhangthen
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Jun 12, 2019

Codecov Report

Merging #1195 into develop will increase coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1195      +/-   ##
=============================================
+ Coverage       43.4%   43.52%   +0.11%     
- Complexity      1428     1430       +2     
=============================================
  Files            250      250              
  Lines          10222    10225       +3     
  Branches        1333     1332       -1     
=============================================
+ Hits            4437     4450      +13     
+ Misses          5202     5189      -13     
- Partials         583      586       +3
Impacted Files Coverage Δ Complexity Δ
...java/io/seata/spring/tcc/TccActionInterceptor.java 12.82% <0%> (-1.07%) 2 <0> (ø)
...java/io/seata/server/lock/memory/MemoryLocker.java 83.69% <0%> (-2.18%) 19% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 33.33% <0%> (-0.53%) 12% <0%> (-1%)
...server/store/file/FileTransactionStoreManager.java 46.34% <0%> (+0.34%) 19% <0%> (ø) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 64.56% <0%> (+0.78%) 24% <0%> (ø) ⬇️
...main/java/io/seata/core/rpc/netty/RmRpcClient.java 29.29% <0%> (+1.01%) 10% <0%> (+1%) ⬆️
...eata/core/rpc/netty/AbstractRpcRemotingClient.java 18.42% <0%> (+1.31%) 6% <0%> (ø) ⬇️
...eata/core/rpc/netty/NettyClientChannelManager.java 70.27% <0%> (+3.6%) 22% <0%> (+2%) ⬆️
...a/server/session/file/FileBasedSessionManager.java 51.78% <0%> (+6.25%) 20% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0071943...c78fa0b. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ujjboy ujjboy merged commit 442e048 into apache:develop Jun 13, 2019
@leizhiyuan leizhiyuan added this to the 0.7.0 milestone Jun 19, 2019
@leizhiyuan leizhiyuan modified the milestone: 0.7.0 Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants