-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature:support batch update and batch delete #1353
feature:support batch update and batch delete #1353
Conversation
…nto feature/batch/updateAndDelete
Codecov Report
@@ Coverage Diff @@
## develop #1353 +/- ##
=============================================
- Coverage 48.6% 48.53% -0.08%
Complexity 1645 1645
=============================================
Files 331 331
Lines 11535 11566 +31
Branches 1430 1445 +15
=============================================
+ Hits 5607 5613 +6
- Misses 5306 5330 +24
- Partials 622 623 +1
Continue to review full report at Codecov.
|
3 similar comments
Codecov Report
@@ Coverage Diff @@
## develop #1353 +/- ##
=============================================
- Coverage 48.6% 48.53% -0.08%
Complexity 1645 1645
=============================================
Files 331 331
Lines 11535 11566 +31
Branches 1430 1445 +15
=============================================
+ Hits 5607 5613 +6
- Misses 5306 5330 +24
- Partials 622 623 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #1353 +/- ##
=============================================
- Coverage 48.6% 48.53% -0.08%
Complexity 1645 1645
=============================================
Files 331 331
Lines 11535 11566 +31
Branches 1430 1445 +15
=============================================
+ Hits 5607 5613 +6
- Misses 5306 5330 +24
- Partials 622 623 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #1353 +/- ##
=============================================
- Coverage 48.6% 48.53% -0.08%
Complexity 1645 1645
=============================================
Files 331 331
Lines 11535 11566 +31
Branches 1430 1445 +15
=============================================
+ Hits 5607 5613 +6
- Misses 5306 5330 +24
- Partials 622 623 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #1353 +/- ##
=============================================
- Coverage 45.54% 45.43% -0.11%
- Complexity 1661 1662 +1
=============================================
Files 345 345
Lines 12667 12683 +16
Branches 1598 1607 +9
=============================================
- Hits 5769 5763 -6
- Misses 6250 6272 +22
Partials 648 648
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
rm-datasource/src/main/java/io/seata/rm/datasource/sql/druid/BaseRecognizer.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/exec/DeleteExecutor.java
Show resolved
Hide resolved
ps.setObject(i + 1, paramAppender.get(i)); | ||
} | ||
} else { | ||
for (int i = 1; i < paramAppenders.size(); i++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UNION -> OR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function test pass.
pstPK.setObject(i + 1, paramAppender.get(i)); | ||
} | ||
} else { | ||
for (int i = 1; i < paramAppenders.size(); i++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What scene?
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews